feat: add named prom port to dataplane sidecar #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanStough
added
the
pr/no-backport
DanStough
force-pushed
the
dans/named-dataplane-prom-port
branch
from
b08f8a5
to
fd6bd7c
Compare
2 tasks
|
@DanStough I would backport to at least 1.3.0 since right now there is no option for folks to use this feature and they will have to wait until v2 is GA. |
DanStough
added
backport/1.3.x
and removed
pr/no-backport
curtbushko
requested changes
Nov 20, 2023
control-plane/connect-inject/webhook/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Hamish <hamish.forbes@gmail.com>
DanStough
force-pushed
the
dans/named-dataplane-prom-port
branch
from
fd6bd7c
to
08900f6
Compare
2 tasks
sarahalsmiller
pushed a commit
that referenced
this pull request
Jan 5, 2024
* feat: add named prom port to dataplane sidecar Co-authored-by: Hamish <hamish.forbes@gmail.com> * PR Feedback --------- Co-authored-by: Hamish <hamish.forbes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
prometheusto the container. This can be used for the Prometheus operator.This could easily be backported to previous versions, but I figured there was no point in the risk, considering how long this issue has been around. Let me know if anyone disagrees. I will need to do it manually to remove the V2 changes.
How I've tested this PR: unit tests
How I expect reviewers to test this PR: 馃憖
Checklist: