Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying ingressClassName for UI ingress #897

Closed
jmezach opened this issue Dec 3, 2021 · 2 comments · Fixed by #909
Closed

Allow specifying ingressClassName for UI ingress #897

jmezach opened this issue Dec 3, 2021 · 2 comments · Fixed by #909
Labels
type/enhancement New feature or request

Comments

@jmezach
Copy link

jmezach commented Dec 3, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Is your feature request related to a problem? Please describe.

We are currently trying to rollout Consul to our Kubernetes cluster. We have a non-default nginx ingress controller setup that uses a custom ingress class. Unfortunately it appears there is no way to set the ingressClassName for the UI ingress object using the Chart currently, which means we are unable to access the Consul UI on our cluster.

Feature Description

By adding the ability to specify an ingressClassName for the UI ingress we can expose the Consul UI from our Kubernetes cluster.

Use Case(s)

This is useful if you have a non-default Kubernetes cluster with some additional requirements.

Contributions

This would probably not be a big change so I wouldn't mind sending in a PR if it has a chance of being accepted.

@jmezach jmezach added the type/enhancement New feature or request label Dec 3, 2021
@t-eckert
Copy link
Contributor

t-eckert commented Dec 6, 2021

Hi @jmezach,

I think this could be a great feature and we would be open to you submitting it as a PR. Thank you for suggesting it and being willing to develop it.

@david-yu
Copy link
Contributor

david-yu commented Dec 6, 2021

@jmezach There was a community PR that was submitted not long ago for this feature: https://github.com/hashicorp/consul-k8s/pull/780/files.

Could you tell us if this PR actually works for you as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants