Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service resolver/splitter/router with partitions #908

Merged
merged 13 commits into from
Dec 8, 2021
Merged

Update service resolver/splitter/router with partitions #908

merged 13 commits into from
Dec 8, 2021

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Dec 7, 2021 •
edited
Loading

Changes proposed in this PR:

  • Update the service router, service splitter and service resolver config entries with partition references.

How I've tested this PR:

  • unit and acceptance tests.
    How I expect reviewers to test this PR:
  • code review

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@thisisnotashwin thisisnotashwin force-pushed the update-acceptance-for-tproxy branch 2 times, most recently from 471f751 to eb2f4c8 Compare December 7, 2021 20:42
@thisisnotashwin thisisnotashwin force-pushed the update-crds-with-partitions branch 2 times, most recently from 6d0a4e1 to f6b8e6f Compare December 7, 2021 20:55
@thisisnotashwin thisisnotashwin requested review from a team, ndhanushkodi and t-eckert and removed request for a team December 7, 2021 20:55
@thisisnotashwin thisisnotashwin marked this pull request as ready for review December 7, 2021 20:56
@thisisnotashwin thisisnotashwin requested review from kschoche and removed request for ndhanushkodi December 7, 2021 20:56
@thisisnotashwin thisisnotashwin force-pushed the update-crds-with-partitions branch 2 times, most recently from 53cd714 to cfcd544 Compare December 8, 2021 15:00
Base automatically changed from update-acceptance-for-tproxy to main December 8, 2021 17:47
@thisisnotashwin thisisnotashwin merged commit b7f9331 into main Dec 8, 2021
@thisisnotashwin thisisnotashwin deleted the update-crds-with-partitions branch December 8, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschoche kschoche kschoche approved these changes

@t-eckert t-eckert Awaiting requested review from t-eckert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thisisnotashwin @kschoche