Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: replication broken when config read from file path #69

Closed
sitano opened this issue Jan 25, 2017 · 2 comments
Closed

Bug: replication broken when config read from file path #69

sitano opened this issue Jan 25, 2017 · 2 comments

Comments

@sitano
Copy link
Contributor

sitano commented Jan 25, 2017

The bug is here https://github.com/hashicorp/consul-replicate/blob/master/config.go#L360 and at #L369.

In #L360 it's passing prefix.Source which in case of config should not contain @dc suffix, because this kind of data now sits in separate field.

Thus, dep.NewKVListQuery misses the point of extracting source datacenter from file config.

Then, assigning in #L369 assumes there is no @dc suffix in the source. So, both possible configuration options ends up broken with file config.

@sitano
Copy link
Contributor Author

sitano commented Jan 25, 2017

This is ongoing fix to #67 #66

@sitano
Copy link
Contributor Author

sitano commented Jan 25, 2017

Personally, I would change dep.NewKVListQuery arguments to exactly accept dc and prefix, thus, omitting the parsing side effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants