We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The bug is here https://github.com/hashicorp/consul-replicate/blob/master/config.go#L360 and at #L369.
In #L360 it's passing prefix.Source which in case of config should not contain @dc suffix, because this kind of data now sits in separate field.
Thus, dep.NewKVListQuery misses the point of extracting source datacenter from file config.
Then, assigning in #L369 assumes there is no @dc suffix in the source. So, both possible configuration options ends up broken with file config.
The text was updated successfully, but these errors were encountered:
This is ongoing fix to #67 #66
Sorry, something went wrong.
Personally, I would change dep.NewKVListQuery arguments to exactly accept dc and prefix, thus, omitting the parsing side effect.
No branches or pull requests
The bug is here https://github.com/hashicorp/consul-replicate/blob/master/config.go#L360 and at #L369.
In #L360 it's passing prefix.Source which in case of config should not contain @dc suffix, because this kind of data now sits in separate field.
Thus, dep.NewKVListQuery misses the point of extracting source datacenter from file config.
Then, assigning in #L369 assumes there is no @dc suffix in the source. So, both possible configuration options ends up broken with file config.
The text was updated successfully, but these errors were encountered: