Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-only import variation failure when importing consul-template and k8s.io/helm #1133

Closed
sbueringer opened this issue Aug 21, 2018 · 4 comments · Fixed by #1139
Closed

Comments

@sbueringer
Copy link
Contributor

sbueringer commented Aug 21, 2018

Consul Template version

v0.19.5

Expected behavior

What should have happened?

I'm trying to build a command-line tool which uses consul-template as well as some Helm rendering capabilities. Therefore, I have dependencies to consul-template and k8s.io/helm and I'm trying to vendor both. dep ensure should run successful.

Actual behavior

What actually happened?

dep ensure leads to Case-only import variation failures. This happens because consul-template as well as helm has imports to "github.com/BurntSushi/toml".
Consul-template imports it as:

  • "github.com/burntsushi/toml" link

Helm imports it as:

  • "github.com/BurntSushi/toml" link

BurntSushi/toml refers to itself by BurntSushi/toml link

I'm not sure which one is idiomatic, but one possible fix would be if consul-template could import BurntSushi/toml the same way as helm. I could/would open a PR if that's an option for you.

References

Are there any other GitHub issues (open or closed) that should
be linked here? For example:

@sbueringer
Copy link
Contributor Author

/cc @sethvargo

@sbueringer
Copy link
Contributor Author

Is this project still maintained?

@eikenb
Copy link
Contributor

eikenb commented Jun 14, 2019

Hey @sbueringer, sorry for the long delay in response. The package was sort of in limbo for a time while but is now maintained again... or at least on its way to. I recently took on the maintainer role for the project and am working through things now.

I'll look into changing that import name as that does seem like the best solution to the issue. I'm planning on 1 update to the dep managed vendored packages before migrating to go-modules and will try to include #1139 in that (and keep the fix in go-modules).

Thanks.

@sbueringer
Copy link
Contributor Author

@eikenb Thanks, no problem. Nice to hear the project is maintained again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants