Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update topology endpoint to account for transparent proxy #10016

Merged
merged 4 commits into from Apr 15, 2021
Merged

Update topology endpoint to account for transparent proxy #10016

merged 4 commits into from Apr 15, 2021

Conversation

freddygv
Copy link
Contributor

@freddygv freddygv commented Apr 14, 2021 •
edited

This PR ensures that we return:

  • Upstreams and downstreams from intentions
  • Whether all instances of a service's proxies are in transparent mode
  • The default allow policy

TODO after beta:

  • Refactor/break up the catalog function

@freddygv freddygv requested a review from a team April 14, 2021 16:45
@vercel vercel bot temporarily deployed to Preview – consul April 14, 2021 16:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 14, 2021 16:52 Inactive
rboyer
rboyer reviewed Apr 15, 2021
View reviewed changes
agent/consul/state/catalog.go
maxIdx = idx
}
if len(proxies) == 0 {
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took me a minute to realize you were using this to skip over the rest of the switch/case block

rboyer
rboyer approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2021 19:58 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2021 19:58 Inactive
@freddygv freddygv merged commit 3be304b into master Apr 15, 2021
@freddygv freddygv deleted the topology-update branch April 15, 2021 20:11
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/351706.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freddygv @hashicorp-ci @rboyer