ui: remove old nspace argument from the proxy instance repository #10039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra argument meant that the blocking query configuratiopn wasn't being read properly, and therefore the correct ?index wasn't being sent with the request.
|
To clarify, this issue was introduced in #9746, which was not backported to the Changelog entry for beta1 would be good, we'll collapse those down to remove intermediate changes when doing the final 1.10.0 GA release, but helpful for now. |
|
Changelog added, just needs an approval now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra argument meant that the blocking query configuration wasn't
being read properly, and therefore the correct ?index wasn't being sent
with the request.
The error was introduced after our last 1.9.x release (but it is in the 1.10-0-alpha), hence no backport.
@mikemorris are we adding changelog entries for things which were broken in 1.10.0-alpha and fixed here?