ui: Adds human formatting to nanosecond based session durations #10062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2021 11:53
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/358197. |
|
🍒✅ Cherry pick of commit 345765f onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Apr 28, 2021
* ui: Adds human formatting to nanosecond based session durations
johncowen
added a commit
that referenced
this pull request
Apr 28, 2021
* ui: Adds human formatting to nanosecond based session durations
|
Little note here, I manually backported this to 1.9.x, but its pretty different in 1.8.x and in everything previous to 1.9.0 it shows the correct value just its not human formatted - so I don't think this absolutely needs to go onto 1.8 |
johncowen
added a commit
that referenced
this pull request
May 4, 2021
…) (#10141) * ui: Adds human formatting to nanosecond based session durations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds human formatting to our nanosecond based session duration values.
The functionality makes use of the
pretty-msJS package, which also includes an option for formatting 'subMilliseconds' which in our case is useful for formatting to nanosecond precision (used by the session duration values).We've used a new
temporalservice to do this, which uses the above package to format numbers only for the moment (we can add further types in a central place when needed, and there's a dev warning if you pass anything but a number to the method). The is a tiny bit of extra functionality on top for the above package:pretty-msseparates units with a space, so I split-joined the spaces out.Notes:
The temporal service (and helper) naming around that is 'inspired' by the t39 temporal proposal which is in Stage 3, which hopefully gives hints to anyone reading the code what it is used for and assumptions on how it could work, its also nice not to have to think about naming things.
If we get to the point that the temporal proposal has a wide enough native support and covers our use cases, we can drop the third-party package and use that from within the service instead.
Helper documentation is also added, which was also handy to use for manual 'get it working' testing, plus I 'filled out' the ember generated automated tests. I also added the default value of the session duration to our acceptance tests.
Changelog to come. I'll try and auto backport to 1.8/1.9/1.10 but off the top of my head it will probably need a little manual intervention to get it down to 1.8.