Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Update not-defined intention popover and banner #10133

Merged
merged 2 commits into from
Apr 28, 2021
Merged

ui: Update not-defined intention popover and banner #10133

merged 2 commits into from
Apr 28, 2021

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Apr 27, 2021

Update the wording for the banner and the popover for a service with an upstream that is not explicitly defined.

Before
Screen Shot 2021-04-27 at 2 41 58 PM

After
Screen Shot 2021-04-27 at 2 42 42 PM

@kaxcode kaxcode added the theme/ui Anything related to the UI label Apr 27, 2021
@kaxcode kaxcode requested a review from johncowen April 27, 2021 18:47
@kaxcode
Copy link
Contributor Author

kaxcode commented Apr 27, 2021 •
edited
Loading

@johncowen not sure if this should be considered a bug/feature. This is an update. LMK what you think so I can make the changelog. I've used improvement for changelog type.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 27, 2021 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 27, 2021 20:34 Inactive
johncowen
johncowen approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

ui/packages/consul-ui/translations/components/consul/en-us.yaml Show resolved Hide resolved
ui/packages/consul-ui/app/components/topology-metrics/down-lines/index.hbs Show resolved Hide resolved
@kaxcode kaxcode merged commit 0c9555e into master Apr 28, 2021
@kaxcode kaxcode deleted the ui/bug/reword-banner-and-popover branch April 28, 2021 14:31
mikemorris pushed a commit that referenced this pull request May 5, 2021
@kaxcode @mikemorris
ui: Update not-defined intention popover and banner (#10133)
5f5d9b7
mikemorris pushed a commit that referenced this pull request May 5, 2021
@kaxcode @mikemorris
ui: Update not-defined intention popover and banner (#10133)
bc0f175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaxcode @johncowen