Save exposed ports in agent's store and expose them via API #10173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddygv
reviewed
May 6, 2021
ishustava
force-pushed
the
expose-exposed-ports
branch
from
73e388a
to
b31aea2
Compare
freddygv
reviewed
May 10, 2021
freddygv
reviewed
May 10, 2021
ishustava
force-pushed
the
expose-exposed-ports
branch
from
dadad44
to
af90ac7
Compare
ishustava
force-pushed
the
expose-exposed-ports
branch
from
af90ac7
to
8efcfeb
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/368156. |
|
🍒✅ Cherry pick of commit d7d44f6 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 12, 2021
* Save exposed HTTP or GRPC ports to the agent's store * Add those the health checks API so we can retrieve them from the API * Change redirect-traffic command to also exclude those ports from inbound traffic redirection when expose.checks is set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See @freddygv 's comment for more info about why we need this change.
This PR changes the following:
redirect-trafficcommand to also exclude those ports from inbound traffic redirection when expose.checks is set to true.Notes:
mogfrom WIP: mog: code gen tool for converting api types into core types #8604 to generate the structsTODO: