usagemetrics: add cluster members to metrics API #10340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized that |
mkeeler
reviewed
Jun 3, 2021
pcewing
force-pushed
the
pcewing/f-member-metrics
branch
from
0091514
to
0a508b7
Compare
mkeeler
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
LGTM. I think we also need to update the telemetry docs in this table here: https://github.com/hashicorp/consul/blob/master/website/content/docs/agent/telemetry.mdx#metrics-reference
mkeeler
reviewed
Jun 3, 2021
pcewing
force-pushed
the
pcewing/f-member-metrics
branch
from
279fa64
to
e4b6563
Compare
pcewing
force-pushed
the
pcewing/f-member-metrics
branch
from
5aae991
to
4b762d2
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/380096. |
|
🍒✅ Cherry pick of commit 42a51b1 onto |
pcewing
pushed a commit
that referenced
this pull request
Jun 3, 2021
This PR adds cluster members to the metrics API. The number of members per segment are reported as well as the total number of members. Tested by running a multi-node cluster locally and ensuring the numbers were correct. Also added unit test coverage to add the new expected gauges to existing test cases.
pcewing
pushed a commit
that referenced
this pull request
Jun 3, 2021
This PR adds cluster members to the metrics API. The number of members per segment are reported as well as the total number of members. Tested by running a multi-node cluster locally and ensuring the numbers were correct. Also added unit test coverage to add the new expected gauges to existing test cases.
freddygv
pushed a commit
that referenced
this pull request
Jun 10, 2021
This PR adds cluster members to the metrics API. The number of members per segment are reported as well as the total number of members. Tested by running a multi-node cluster locally and ensuring the numbers were correct. Also added unit test coverage to add the new expected gauges to existing test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cluster members to the metrics API. The number of members per
segment are reported as well as the total number of members.
Tested by running a multi-node cluster locally and ensuring the numbers were
correct. Also added unit test coverage to add the new expected gauges to
existing test cases.