Revert "Avoid adding original_dst filter when not needed" #10365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 19334e8.
freddygv
changed the title
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/382927. |
|
🍒✅ Cherry pick of commit 7577f0e onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 19334e8.
The addition of the "original_dst" filter does not depend on the mesh config, only on whether the proxy is in transparent mode.
The PR to revert made it so that transparent proxying didn't work when
Mesh.TransparentProxy.CatalogDestinationsOnlywas set totruebecause Envoy couldn't recover the original IP address before iptables redirection.