Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect/ca/roots endpoint do not return the intermediate cert when using vault provider #10532

Closed
dhiaayachi opened this issue Jun 30, 2021 · 3 comments · Fixed by #11671
Closed

connect/ca/roots endpoint do not return the intermediate cert when using vault provider #10532

dhiaayachi opened this issue Jun 30, 2021 · 3 comments · Fixed by #11671
Labels
theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/bug Feature does not function as expected

Comments

@dhiaayachi
Copy link
Collaborator

When using a vault provider with consul and starting a new server. the call to v1/connect/ca/roots will not return an intermediate cert until half the root cert life time passed.

This happen because in getIntermediateCAPrimary we don't store the generated intermediate in raft
@dhiaayachi dhiaayachi added theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies labels Jun 30, 2021
Closed
@jkirschner-hashicorp jkirschner-hashicorp added the type/bug Feature does not function as expected label Aug 16, 2021
@dnephin
Copy link
Contributor

dnephin commented Aug 17, 2021

Thinking about this more, the issue might not simply be the API missing data. Envoy also won't receive the intermediate cert, which would mean the TLS chain can not be verified and it could lead to services not being able to connect to each other.

@dnephin
Copy link
Contributor

dnephin commented Nov 1, 2021

#10826 sounds like it might be the same issue

@dnephin
Copy link
Contributor

dnephin commented Nov 25, 2021

After looking at this more, I think Envoy is fine because it gets the intermediates from the Sign leaf API call, not from the response of /connect/ca/roots, but this is still a problem for anyone using the API.

This was referenced Nov 25, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/bug Feature does not function as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ca: fix storing the leaf signing cert with Vault provider hashicorp/consul
3 participants
@dnephin @dhiaayachi @jkirschner-hashicorp