Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service checks are not shown in lock session summary #10754

Closed
dantheoptimist opened this issue Aug 2, 2021 · 2 comments · Fixed by #10767
Closed

Service checks are not shown in lock session summary #10754

dantheoptimist opened this issue Aug 2, 2021 · 2 comments · Fixed by #10767
Labels
theme/ui Anything related to the UI

Comments

@dantheoptimist
Copy link

dantheoptimist commented Aug 2, 2021

Overview of the Issue

When using service checks on a session to lock a key/value, the service checks are not rendered correctly in the lock session summary.

Reproduction Steps

  1. Create a session with a service check e.g. curl -X PUT -d '{"Name": "myservice", "ServiceChecks":[{"ID":"myServiceCheck"}]}' http://localhost:8500/v1/session/create
  2. Lock a value using the session that was created e.g. curl -X PUT -d '{"Application": "test", "host":"somehost", "port":1234}' http://localhost:8500/v1/kv/example/key?acquire=933fd1dd-83fd-e3be-dab4-f5dfab2e33eb
  3. View the key value in the UI by navigating to Key/Value -> example -> key and see the service check is rendered as a generic object obscuring the check ID.

image

Consul info for both Client and Server

Client and server running 1.10.0

@dantheoptimist
Copy link
Author

This looks to be due to the UI and tests expecting the response to be formatted as per the incorrect documentation noted in #10752.

It may be sufficient to use the ID field directly when joining on to the list of checks for most use cases, it would also be necessary to update the test data that covers this use case.

@blake blake added the theme/ui Anything related to the UI label Aug 3, 2021
@kaxcode
Copy link
Contributor

kaxcode commented Aug 4, 2021

@dantheoptimist thank you for reporting this. We've updated our API docs and made changes to our UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants