Return every time lock acquisition fails #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbottscott
force-pushed
the
master
branch
2 times, most recently
from
f0052fd
to
f85c94e
Compare
|
@armon or others, can I get a review on this, time permitting? |
|
@babbottscott Does this change the behavior? It seems like the same behavior as before |
armon
added a commit
that referenced
this pull request
Jul 22, 2015
Return every time lock acquisition fails
|
NVM I see the output is much improved, thanks! |
|
It's not just output. The previous test would continue when err was nil, even though lockCh was also nil. If lockCh is nil, it must return. |
|
In any event, many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #800
Not sure how to pursue a negative test case for this.