Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KVUsage to consul state usage metrics #11090

Merged
merged 6 commits into from
Sep 22, 2021
Merged

Add KVUsage to consul state usage metrics #11090

merged 6 commits into from
Sep 22, 2021

Conversation

clly
Copy link
Contributor

@clly clly commented Sep 20, 2021

No description provided.

This change will add the number of entries in the consul KV store to the
already existing usage metrics.
This will add information about the new kv_usage metric to the website
@clly clly requested a review from a team as a code owner September 20, 2021 17:48
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 20, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 20, 2021 17:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul September 20, 2021 17:52 Inactive
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from a docs perspective

@vercel vercel bot temporarily deployed to Preview – consul September 20, 2021 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 20, 2021 18:45 Inactive
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I left a few comments but they are ultra-nitpicky.

agent/consul/state/usage_test.go Outdated Show resolved Hide resolved
agent/consul/usagemetrics/usagemetrics.go Outdated Show resolved Hide resolved
agent/consul/usagemetrics/usagemetrics.go Outdated Show resolved Hide resolved
Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – consul September 21, 2021 15:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 21, 2021 15:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul September 22, 2021 16:05 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 22, 2021 16:05 Inactive
@clly clly merged commit 1e3ba26 into main Sep 22, 2021
@clly clly deleted the clly/kv-usage-metrics branch September 22, 2021 16:26
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/453132.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 1e3ba26 onto release/1.11.x succeeded!

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 1e3ba26 onto release/1.10.x failed! Build Log

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 1e3ba26 onto release/1.9.x failed! Build Log

clly added a commit that referenced this pull request Sep 22, 2021
Add KVUsage to consul state usage metrics
clly added a commit that referenced this pull request Sep 22, 2021
Add KVUsage to consul state usage metrics
clly added a commit that referenced this pull request Sep 23, 2021
clly added a commit that referenced this pull request Sep 23, 2021
@@ -36,6 +36,10 @@ var Gauges = []prometheus.GaugeDefinition{
Name: []string{"consul", "members", "servers"},
Help: "Measures the current number of server agents registered with Consul. It is only emitted by Consul servers. Added in v1.9.6.",
},
{
Name: []string{"consul", "kv", "entries"},
Help: "Measures the current number of server agents registered with Consul. It is only emitted by Consul servers. Added in v1.10.3.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Measures the current number of unique KV entries written in Consul. It is only emitted by Consul servers. Added in v1.10.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants