ui: [Backport] Backport of #11095 to 1.8.x #11102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). consul – ./website🔍 Inspect: https://vercel.com/hashicorp/consul/qJJUtdcqeoeKQaFSswNRUD3HSLMf [Deployment for 05e5bc0 failed] consul-ui-staging – ./ui🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/BuFu86gmsSPnzwMAh1yF2yLHDznv [Deployment for 05e5bc0 failed] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11095. Whilst this is a backport it only fixes the visual issue with the namespace menus (doubling up of selectable elements in the menu). The main issue that #11095 fixes is not an issue in 1.8.x as the original fix for this issue was never backported to 1.8.x.
I've included the tests I copy/pasted for 1.9.x, 1.10.x and 1.11.x here also, even though the bug introduced in those versions is not an issue in 1.8.x, it's still maybe useful to have those here also.