plumb thru root cert tll to the aws ca provider #11449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
theme/connect
acpana
commented
Oct 29, 2021
17 tasks
acpana
force-pushed
the
ffmmm/f-10762
branch
2 times, most recently
from
bd12b92
to
9725132
Compare
acpana
changed the title
Merged
Signed-off-by: FFMMM <FFMMM@users.noreply.github.com>
acpana
force-pushed
the
ffmmm/f-10762-acmpca
branch
from
7b7dafc
to
d607482
Compare
acpana
changed the title
dhiaayachi
reviewed
Nov 4, 2021
| @@ -33,9 +33,6 @@ const ( | |||
| // leaf cert. | |||
| LeafTemplateARN = "arn:aws:acm-pca:::template/EndEntityCertificate/V1" | |||
|
|
|||
| // RootTTL is the validity duration for root certs we create. | |||
| AWSRootTTL = 5 * 365 * 24 * time.Hour | |||
|
|
|||
| // IntermediateTTL is the validity duration for the intermediate certs we | |||
| // create. | |||
| AWSIntermediateTTL = 1 * 365 * 24 * time.Hour | |||
There was a problem hiding this comment.
probably in a subsequent PR, but I think we can also make this configurable.
There was a problem hiding this comment.
the AWSRootTTL is actually replaced by the RootCertTTL option :)
dhiaayachi
reviewed
Nov 4, 2021
dhiaayachi
approved these changes
Nov 4, 2021
Co-authored-by: Dhia Ayachi <dhia@hashicorp.com>
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/493829. |
dnephin
added
theme/certificates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branching off from #11428
PR adds root cert ttl config to AWS CA provider.
Testing
PR Checklist
Signed-off-by: FFMMM FFMMM@users.noreply.github.com