ui: Disable setting wildcard partitions for intentions #11804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msiege2
approved these changes
Dec 13, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/525926. |
|
🍒✅ Cherry pick of commit 2ba0e86 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to select a wildcard partition when trying to make an intention, but as this is not possible, when doing so you would see one of our UI backend errors, which is a little confusing.
Preview link for this PR notice the 2 partition menus have 'default' in them, not
* (All Partitions).Borken Preview Link is very borken as it lets you specify
* (All Partitions)which leads to the response when you try to save an intention into a non-mock Consul being very borked 😅This PR removes being able to select a wildcard partition from the intention menus.