ui: Various empty state improvements/fixups #11892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 20, 2021 12:31
Previous to this fix we would not show a more tailored message for when you empty result set was due to a user search rather than an empty result set straight from the backend
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/534820. |
|
🍒✅ Cherry pick of commit 2c1eb05 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Dec 21, 2021
* ui: Add login button to per service intentions for zero results * Add login button and consistent header for when you have zero nodes * `services` doesn't exists use `items` consequently: Previous to this fix we would not show a more tailored message for when you empty result set was due to a user search rather than an empty result set straight from the backend * Fix `error` > `@error` in ErrorState plus code formatting and more docs * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONSUL_NODE_COUNT=0cookie value to see this on the node listing page)servicesis now undefined in our Service List template, we should be usingitemsinstead. Consequently our slightly better tailored message wasn't showing at all, with this fix it will. You can see the difference pre and post PR for this one by using the search bar to search for a service that doesn't exist.@in our ErrorState component, the small consequence of this is when we have an error that specified adetailproperty, thedetailwould not show and the error state would use the default text instead. I took the opportunity here to reformat the code slightly in the component, use ourActioncomponent and improve the docs slightly.