Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keys with dashes in web UI #119

Merged
merged 2 commits into from
May 4, 2014
Merged

Allow keys with dashes in web UI #119

merged 2 commits into from
May 4, 2014

Conversation

tiwilliam
Copy link
Contributor

Allow dashes in key names and still be able to view and modify them using the web UI.

URL:s will now look like this:

http://localhost:8500/ui/#/dc1/kv/
http://localhost:8500/ui/#/dc1/kv/folder/
http://localhost:8500/ui/#/dc1/kv/folder/key-with-dashes
http://localhost:8500/ui/#/dc1/kv/folder/key-with-dashes/edit

This will resolve #109.

@pearkes
Copy link
Contributor

pearkes commented May 4, 2014

Fantastic! Great work.

This is way better, and you cleaned up a ton of stuff in there. Thank you, merging!

pearkes added a commit that referenced this pull request May 4, 2014
@pearkes
Merge pull request #119 from tiwilliam/dash-in-keys
34d5c94 
Allow keys with dashes in web UI
@pearkes pearkes merged commit 34d5c94 into hashicorp:master May 4, 2014
@tiwilliam
Copy link
Contributor Author

Thanks! 🍻

johncowen pushed a commit that referenced this pull request May 4, 2018
@pearkes
Merge pull request #119 from tiwilliam/dash-in-keys
61e0258 
Allow keys with dashes in web UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Can't manage keys with dashes
2 participants
@tiwilliam @pearkes