ui: Ensure disconnect error doesn't appear w/auth change on some pages #11905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
added
type/bug
johncowen
force-pushed
the
ui/bugfix/disconnection-error
branch
from
08520db
to
aed9f9b
Compare
amyrlam
approved these changes
Dec 23, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/538725. |
|
🍒✅ Cherry pick of commit 72e5d7e onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Jan 4, 2022
johncowen
added a commit
that referenced
this pull request
Jan 4, 2022
johncowen
added a commit
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated a bug were in certain configurations you could log in but the view of data would not be refreshed/re-requested using the new token that you logged in with. Details in #11681.
The approach in the mentioned PR was to use a client generated 401 error to cancel out all running blocking queries and immediately start them up again using the new token.
Unfortunately, on some pages where things can disappear whilst blocking on them (for instance a service might be deregistered whilst viewing the service detail page), we catch any errors and show a message saying the connection was lost for some reason. In some circumstances we get an error that we can safely ignore, and these are usually our client generated errors (such as our 429 errors which are produced when we force cancel a blocking query due to reaching our connection limit).
As we added a new client generated error code in the above PR (401) we should have also made sure to ignore that error code also, which is what this PR adds in a place that is somewhat 'global'.