ui: Adds a notice for non-primary intention creation #11985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
added
type/enhancement
LGTM
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/549924. |
|
🍒✅ Cherry pick of commit 9192452 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot specify partitions whilst creating intentions if you are not in the primary datacenter.
Here we check to see if we have partitions enabled, then see if we are prohibited from 'choosing' them using our ability for partitions, in which case we show the notice which is just a simple-ish presentational component.
We only do this for the create screen, and as the
isManagedByCRDsnotice was intertwined with this conditional previously, we split that up here.