Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: List Primary and Local DCs first in the Datacenter selector #12478

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Mar 1, 2022

This PR orders the Datacenter selector/menu as:

  1. Primary DC first
  2. Local DC second
  3. All the rest alphabetically

We figured Primary should go before Local (local is the one the UI is running on) but if anyone reads this and thinks otherwise please ping ty!

@github-actions github-actions bot added the theme/ui Anything related to the UI label Mar 1, 2022
@johncowen johncowen marked this pull request as ready for review March 1, 2022 14:26
@johncowen johncowen requested review from a user, amyrlam, natmegs and jgwhite March 1, 2022 14:27
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 7, 2022 10:41 Inactive
@vercel vercel bot temporarily deployed to Preview – consul March 7, 2022 10:41 Inactive
@johncowen
Copy link
Contributor Author

Gettin' on the merge train

@johncowen johncowen merged commit 7a1c3a8 into main Mar 7, 2022
@johncowen johncowen deleted the ui/feature/dc-ordering branch March 7, 2022 10:54
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/603602.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants