ui: Fix loading icon size (adds a viewbox) #12479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrowe
approved these changes
Mar 4, 2022
ghost
approved these changes
Mar 4, 2022
|
Wasn't entirely sure how far this went back, I just checked 1.10.x and that branch is fine, so this one is just going onto 1.11.x plus main |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/603519. |
johncowen
added a commit
that referenced
this pull request
Mar 7, 2022
johncowen
added a commit
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Weirdly this isn't currently using the flight icon but I know this one was late coming in flight so maybe thats why. It's kinda handy as I want to backport this, plus there are other icon related PRs in-flight (honestly didn't mean that 😆 ), so once this is all down I'll triple check this again.