Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: Add Envoy 1.22 to integration tests, remove Envoy 1.18 #12805

Merged
merged 11 commits into from
Apr 18, 2022
Merged

connect: Add Envoy 1.22 to integration tests, remove Envoy 1.18 #12805

merged 11 commits into from
Apr 18, 2022

Conversation

eculver
Copy link
Contributor

@eculver eculver commented Apr 15, 2022

Envoy 1.22.0 was released today. This adds it to our test matrix and removes 1.18.6.

@eculver eculver requested review from rboyer and a team April 15, 2022 19:23
@eculver eculver requested a review from a team as a code owner April 15, 2022 19:23
@github-actions github-actions bot added theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified labels Apr 15, 2022
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 19:26 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 19:26 Inactive
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
agent/xds/envoy_versioning.go Outdated
@@ -11,7 +11,7 @@ import (
var (
// minSupportedVersion is the oldest mainline version we support. This should always be
// the zero'th point release of the last element of proxysupport.EnvoyVersions.
minSupportedVersion = version.Must(version.NewVersion("1.18.0"))
minSupportedVersion = version.Must(version.NewVersion("1.19.0"))

minVersionToForceLDSandCDSToAlwaysUseWildcardsOnReconnect = version.Must(version.NewVersion("1.19.0"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted too now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh right, I meant to get that. thanks!

rboyer
rboyer approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass and you remove that one last piece of dead code.

@rboyer rboyer added backport-inactive/1.12 This release series is no longer active and removed backport-inactive/1.12 This release series is no longer active labels Apr 15, 2022
@rboyer rboyer added this to the 1.12.0 milestone Apr 15, 2022
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 20:00 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 20:00 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 18, 2022 07:05 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 18, 2022 07:05 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 18, 2022 07:28 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 18, 2022 07:28 Inactive
@eculver eculver added the backport-inactive/1.12 This release series is no longer active label Apr 18, 2022
@eculver
Copy link
Contributor Author

eculver commented Apr 18, 2022

Thanks @rboyer for jumping in. FWIW, this all looks good to me!

@eculver eculver merged commit 000d062 into main Apr 18, 2022
@eculver eculver deleted the eculver/envoy-1.22.0 branch April 18, 2022 16:36
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/642386.

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 000d062 onto stable-website failed! Build Log

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 000d062 onto release/1.12.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Apr 18, 2022
@eculver @rboyer @hc-github-team-consul-core
connect: Add Envoy 1.22 to integration tests, remove Envoy 1.18 (#12805)
0cec538 
Co-authored-by: R.B. Boyer <rb@hashicorp.com>
@dekimsey dekimsey mentioned this pull request Apr 20, 2022
Open
@dekimsey
Copy link
Collaborator

@eculver just drawing attention to this. Consul 1.12 with Envoy is effectively no longer supported on CentOS 7 with this change. The packaged envoy was getenvoy-envoy from tetratelabs, and builds stopped working with 1.19. CentOS 7 packages have been stuck on 1.18 for sometime while waiting for official builds (if they ever happen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

Assignees
No one assigned
Labels
backport-inactive/1.12 This release series is no longer active theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eculver @hc-github-team-consul-core @dekimsey @rboyer