Update go version to 1.18.1 #12808
Merged
Update go version to 1.18.1 #12808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
pr/dependencies
DanStough
commented
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 15, 2022
DanStough
added
the
backport-inactive/1.12
acpana
reviewed
Apr 15, 2022
rboyer
reviewed
Apr 18, 2022
| @@ -288,3 +290,15 @@ func TestService_HasDefaultHTTPResolverFromAddr(t *testing.T) { | |||
| require.NoError(t, err) | |||
| require.Equal(t, expected, got) | |||
| } | |||
|
|
|||
| func getSubjects(cp *x509.CertPool) string { | |||
There was a problem hiding this comment.
Maybe drop a TODO here for the future to reevaluate the kind of comparison we should do here.
rboyer
approved these changes
Apr 18, 2022
rboyer
approved these changes
Apr 18, 2022
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/642045. |
|
🍒✅ Cherry pick of commit 95250e7 onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to facilitate Go 1.18. Highlights on Changes:
Deprecations:
x509.CertPool.Subjects()Strings.Title()