When a host header is defined override req.Host in the metrics ui
#13071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After merging, confirm that you see messages like: 🍒✅ Cherry pick of commit ... onto ... succeeded! |
2 similar comments
|
After merging, confirm that you see messages like: 🍒✅ Cherry pick of commit ... onto ... succeeded! |
|
After merging, confirm that you see messages like: 🍒✅ Cherry pick of commit ... onto ... succeeded! |
dhiaayachi
requested review from
a team,
kyhavlov and
markan
and removed request for
a team
markan
approved these changes
May 13, 2022
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
1 similar comment
|
After merging, confirm that you see linked PRs AND check that them for CI errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #10164
The behaviour of
req.Header.Setin the gohttppackage ignore the Header when it's named Host. To se the Host header this need to be set inreq.Host.This PR add the ability to do so for the ui internal endpoint, so users can add an
add_headerdirective in Consul config to overwrite the Host header so a proxy can be configured.Note:
Header names are case insensitive as defined in here