Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds network tomography features to Consul. #1331

Merged
merged 59 commits into from
Oct 23, 2015
Merged

Adds network tomography features to Consul. #1331

merged 59 commits into from
Oct 23, 2015

Conversation

slackpad
Copy link
Contributor

This should complete network tomography on the Consul side. There was a pretty major rebase after the memdb changes, so the final commit (ecd3a1d) has the major changes associated with that. That change is worth a quick review, everything else has been reviewed previously.

Here are the biggest changes made during the rebase:

  1. While in here I realized that the state store would accept coordinates for nodes that weren't in the catalog. Since deleting coordinates is tied to deleting nodes, and we don't really control if agents send coordinates before they have successfully been registered in the catalog, this seemed like a potential for inconsistency. I made the state store just skip coordinate updates for nodes not in the catalog, which required some changes to unit tests.
  2. Got rid of the single coordinate get function since it was only used in unit tests.
  3. Beefed up unit tests in some places.
  4. Cleaned up the coordinate types in the structs package.

/cc @armon and/or @ryanuber

derekchiang and others added 30 commits October 23, 2015 15:23
* A batch of updates is done all in a single transaction.
* We no longer need to get an update to kick things, there's a periodic flush.
* If incoming updates overwhelm the configured flush rate they will be dumped with an error.
* Holds coordinate updates in map and gets rid of the update channel.
* Cleans up config variables a bit.
James Phillips added 23 commits October 23, 2015 15:23
@ryanuber
Copy link
Member

LGTM! 🚢

slackpad added a commit that referenced this pull request Oct 23, 2015
Adds network tomography features to Consul.
@slackpad slackpad merged commit 798d49c into hashicorp:master Oct 23, 2015
@slackpad slackpad deleted the f-network-tomography branch October 23, 2015 23:34
dnephin added a commit that referenced this pull request Jul 14, 2021
#128 added pid_file
#1331 added disable_coordinates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants