Respect http2 protocol for upstreams of terminating gateways #13699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
approved these changes
Jul 8, 2022
kyhavlov
force-pushed
the
tgate-http2-upstream
branch
from
94f294a
to
dc5f5f2
Compare
kyhavlov
force-pushed
the
tgate-http2-upstream
branch
from
dc5f5f2
to
7d0c692
Compare
eculver
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with terminating gateway upstreams that have
http2set as the protocol. Currently, the terminating gateway won't communicate to the upstream correctly with the http2 protocol options set - this PR adds that logic inagent/xds/clusters.go