Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Targets field to service resolver failovers. #14162

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

erichaberkorn
Copy link
Contributor

Description

The Targets field is more expressive than the previous way failovers were configured because it allows users to express complicated failover scenarios such as:

Kind           = "service-resolver"
Name           = "web"
ConnectTimeout = "15s"
Failover = {
  "*" = {
    Targets = [
      {
        PeerName = "cluster-01"
        Service = "web-from-peer"
        Namespace = "peer-namespace"
      },
      {
        Datacenter = "dc2"
      }
    ]
  }
}

It will be used to add failover support to partitions and cluster peers.

Testing & Reproduction steps

  • Unit tests - For now this just changes the structs and isn't used anywhere.

PR Checklist

  • updated test coverage
  • external facing docs updated - I'll update the documentation when this feature is complete.
  • not a security concern

@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label Aug 11, 2022
@erichaberkorn erichaberkorn force-pushed the peering-failover-struct-changes branch 4 times, most recently from 1d9f480 to 684cf35 Compare August 12, 2022 19:02
@erichaberkorn erichaberkorn marked this pull request as ready for review August 12, 2022 19:15
This field will be used for cluster peering failover.
Copy link
Collaborator

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erichaberkorn erichaberkorn merged commit 1a73b0c into main Aug 15, 2022
@erichaberkorn erichaberkorn deleted the peering-failover-struct-changes branch August 15, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/api Relating to the HTTP API interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants