Update max_ejection_percent on outlier detection for peered clusters to 100% #14373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaberkorn
force-pushed
the
update-outlier-detection-peered-clusters
branch
from
d1d405b
to
43c2f4d
Compare
kisunji
approved these changes
Aug 29, 2022
kisunji
reviewed
Aug 29, 2022
…to 100% We can't trust health checks on peered services when service resolvers, splitters and routers are used.
erichaberkorn
force-pushed
the
update-outlier-detection-peered-clusters
branch
from
43c2f4d
to
a20aef7
Compare
kisunji
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can't trust health checks when service resolvers, splitters, and routers are used for peered clusters.
PR Checklist