Config-entry: Support proxy config in service-defaults #14395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/api
boruszak
approved these changes
Aug 30, 2022
website/content/docs/connect/config-entries/service-defaults.mdx
Outdated
Show resolved
Hide resolved
mkeeler
approved these changes
Sep 8, 2022
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
huikang
force-pushed
the
support-centralized-local-timeout
branch
from
89e9757
to
e7c190b
Compare
Merged
3 tasks
huikang
added a commit
that referenced
this pull request
Sep 12, 2022
* Config-entry: Support proxy config in service-defaults * Update website/content/docs/connect/config-entries/service-defaults.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
huikang
pushed a commit
that referenced
this pull request
Sep 12, 2022
* Config-entry: Support proxy config in service-defaults * Update website/content/docs/connect/config-entries/service-defaults.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
huikang
pushed a commit
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In current implementation,
local_request_timeout_msandlocal_connect_timeout_mscan only be configured either in proxy.config of individual service instances or the globalproxy-defaults. Sometimes, users want to use theservice-defaultsconfig-entry to propagate the values only to the proxies of the selected service.This PR enables this feature by adding
local_request_timeout_msandlocal_connect_timeout_msto theservice-defaultsconfig-entry.Testing & Reproduction steps
Following is an example of the service-defaults entry with the added fields.
Links
Address #12553
PR Checklist