Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(peering): replicating wan address #15108

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Conversation

huikang
Copy link
Collaborator

@huikang huikang commented Oct 22, 2022

Description

When sending server address to the dialing peer cluster, wan address should be used if there is any.

This PR is consistent to the fix for generating peering token (#15065).

Testing & Reproduction steps

Links

fix #15087

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Copy link
Contributor

@erichaberkorn erichaberkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth adding a test for this, but this looks good to me 👍

@huikang
Copy link
Collaborator Author

huikang commented Oct 24, 2022

It's probably worth adding a test for this, but this looks good to me 👍

Added. Thanks for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transport: Error while dialing failed to find Consul server for global address
2 participants