Adds child process reaping when Consul is running as PID 1. #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ryanuber or @sethvargo for review |
| if !config.DisableReap && (os.Getpid() == 1) { | ||
| logger := c.agent.logger | ||
| if !reap.IsSupported() { | ||
| logger.Printf("[WARN] Running as PID 1 but child process reaping is not supported on this platform, disabling") |
slackpad
added a commit
that referenced
this pull request
Dec 22, 2015
Adds child process reaping when Consul is running as PID 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the same testing methodology as hashicorp/consul-template#479 to make sure this is working (it seems extremely hard to unit test beyond verifying config.
This should fix #1183.
The config behavior is slightly different than CT since Consul can't tell whether the user set an item or not. I looked into adding that but it looked like a big effort, and out of scope for this. This should be zero-config for nearly all use cases, anyway.