[CC-4365] HCP Metrics xDS Config for Envoy #16585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddygv
requested review from
a team,
zalimeni and
hashi-derek
and removed request for
a team
github-actions
bot
added
theme/api
freddygv
force-pushed
the
cc-4365/hcp-metrics-dynamic-listener
branch
from
395ce5d
to
d0c67da
Compare
freddygv
commented
Mar 9, 2023
agent/proxycfg/connect_proxy.go
Outdated
Comment on lines
662
to
664
| DestinationNamespace: acl.DefaultNamespaceName, | ||
| DestinationPartition: s.proxyID.PartitionOrDefault(), | ||
| DestinationName: api.HCPMetricsCollectorName, |
There was a problem hiding this comment.
The collector will be deployed in the default namespace of each admin partition using the well-known api.HCPMetricsCollectorName
freddygv
commented
Mar 9, 2023
agent/proxycfg/connect_proxy.go
Outdated
| DestinationName: api.HCPMetricsCollectorName, | ||
| LocalBindSocketPath: path, | ||
| Config: map[string]interface{}{ | ||
| "protocol": "grpc", |
There was a problem hiding this comment.
Envoy's metrics service stats sink uses gRPC: https://github.com/envoyproxy/envoy/blob/main/api/envoy/service/metrics/v3/metrics_service.proto#L23
freddygv
commented
Mar 9, 2023
| "envoy.extensions.upstreams.http.v3.HttpProtocolOptions": { | ||
| "@type": "type.googleapis.com/envoy.extensions.upstreams.http.v3.HttpProtocolOptions", | ||
| "explicitHttpConfig": { | ||
| "http2ProtocolOptions": {} |
There was a problem hiding this comment.
Expected http2 protocol options since it is a gRPC service
hashi-derek
approved these changes
Mar 9, 2023
agent/proxycfg/connect_proxy.go
Outdated
| s.logger.Error("failed to parse connect.proxy.config", "error", err) | ||
| } | ||
|
|
||
| if hcpCfg.HCPMetricsBindSocketDir != "" { |
There was a problem hiding this comment.
Nit. We should invert this so that it performs an early return when the value is empty.
Achooo
force-pushed
the
cc-4361/hcp-metrics-bootstrap-config
branch
from
307c579
to
8cda1df
Compare
Achooo
force-pushed
the
cc-4361/hcp-metrics-bootstrap-config
branch
from
8c65c58
to
4eb82e1
Compare
freddygv
force-pushed
the
cc-4365/hcp-metrics-dynamic-listener
branch
from
f739e60
to
d6fadc3
Compare
freddygv
merged commit 59d4378
into
cc-4361/hcp-metrics-bootstrap-config
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#16511 adds bootstrap configuration so that Envoy is configured to send its telemetry to a statically defined local socket.
This PR builds on top of the previous one by configuring a dynamic listener at that statically configured socket. The changes below inject the HCP metrics collector as an upstream for connect proxies since it is intended to be a mesh service deployed onto the user's cluster.
Why is there dynamic configuration when the cluster is statically defined at bootstrap time?
Why define the collector as an upstream in
proxycfg?xdspackage.Testing & Reproduction steps
PR Checklist