snapshot: some improvments to the snapshot process #17236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
huikang
added
pr/no-changelog
trujillo-adam
approved these changes
May 8, 2023
Comment on lines
32
to
33
| Another side effect is that one snapshot file is also taken at `data_dir/raft/snapshops`, | ||
| resulting from Raft snapshot. |
There was a problem hiding this comment.
Suggested change
| Another side effect is that one snapshot file is also taken at `data_dir/raft/snapshops`, | |
| resulting from Raft snapshot. | |
| As a result of the Raft snapshot, Consul also saves one snapshot file at `data_dir/raft/snapshops`. |
Is that correct? Consul saves an additional snapshot triggered by the Raft snapshot?
There was a problem hiding this comment.
Yes, this is a result from the raft library.
There was a problem hiding this comment.
But I'd like to have an eng reviewer to confirm. Thanks, @trujillo-adam
|
Hi, @kisunji , this seems related to the logger work you presented yesterday, so add you as the reviewer. Thanks. |
kisunji
reviewed
May 9, 2023
snapshot/snapshot.go
Outdated
| @@ -53,6 +53,7 @@ func New(logger hclog.Logger, r *raft.Raft) (*Snapshot, error) { | |||
| if err != nil { | |||
| return nil, fmt.Errorf("failed to create snapshot file: %v", err) | |||
| } | |||
| logger.Info("creating temporary file of snapshot", "path", archive.Name()) | |||
There was a problem hiding this comment.
Should this be at the debug level? Wondering if it is useful for operators at the INFO level
huikang
force-pushed
the
minor-update-snapshot-logger
branch
from
dbdc105
to
928176c
Compare
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
Co-authored-by: Chris S. Kim <ckim@hashicorp.com>
huikang
force-pushed
the
minor-update-snapshot-logger
branch
from
928176c
to
164cada
Compare
kisunji
approved these changes
May 9, 2023
This was referenced May 9, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
snapshot: some improvments to the snapshot process
raftto the snapshot logger because the log messages are from raft package, making it consistent with other snapshot logs likestarting snapshot up to, which are from the raft package as well. Also it allows users know where to search for the logger messagePrint out the path of the temp snapshot file for trouble shooting
Update the doc a bit
PR Checklist