Fix multiple issues related to proxycfg health queries. #17241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The datacenter was not being provided to a proxycfg query, which resulted in bypassing agentless query optimizations and using the normal API instead. 2. The health rpc endpoint would return a zero index when insufficient ACLs were detected. This would result in the agent cache performing an infinite loop of queries in rapid succession without backoff.
hashi-derek
force-pushed
the
derekm/NET-3881/health-call-loop
branch
from
3301b8c
to
ff4ba95
Compare
hashi-derek
added
backport/1.13
backport/1.15
erichaberkorn
approved these changes
May 8, 2023
malizz
approved these changes
May 8, 2023
erichaberkorn
approved these changes
May 9, 2023
This was referenced May 9, 2023
Closed
Merged
hashi-derek
added a commit
that referenced
this pull request
May 9, 2023
Fix multiple issues related to proxycfg health queries. 1. The datacenter was not being provided to a proxycfg query, which resulted in bypassing agentless query optimizations and using the normal API instead. 2. The health rpc endpoint would return a zero index when insufficient ACLs were detected. This would result in the agent cache performing an infinite loop of queries in rapid succession without backoff.
hashi-derek
added a commit
that referenced
this pull request
May 9, 2023
Fix multiple issues related to proxycfg health queries. 1. The datacenter was not being provided to a proxycfg query, which resulted in bypassing agentless query optimizations and using the normal API instead. 2. The health rpc endpoint would return a zero index when insufficient ACLs were detected. This would result in the agent cache performing an infinite loop of queries in rapid succession without backoff.
hashi-derek
added a commit
that referenced
this pull request
May 9, 2023
) Fix multiple issues related to proxycfg health queries. 1. The datacenter was not being provided to a proxycfg query, which resulted in bypassing agentless query optimizations and using the normal API instead. 2. The health rpc endpoint would return a zero index when insufficient ACLs were detected. This would result in the agent cache performing an infinite loop of queries in rapid succession without backoff.
hashi-derek
added a commit
that referenced
this pull request
May 9, 2023
All tests passed in OSS, but not ENT. This is a patch to resolve the problem for both.
hashi-derek
added a commit
that referenced
this pull request
May 9, 2023
All tests passed in OSS, but not ENT. This is a patch to resolve the problem for both.
hashi-derek
added a commit
that referenced
this pull request
May 9, 2023
This was referenced May 9, 2023
hashi-derek
added a commit
that referenced
this pull request
May 9, 2023
hashi-derek
added a commit
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datacenter was not being provided to a proxycfg query, which resulted in bypassing agentless query optimizations and using the normal API instead.
The health rpc endpoint would return a zero index when insufficient ACLs were detected. This would result in the agent cache performing an infinite loop of queries in rapid succession without backoff.
A follow-up PR was created shortly after to fix a bug caused by this change: #17278