Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSS] gRPC Blocking Queries #17426

Merged
merged 2 commits into from May 23, 2023
Merged

[OSS] gRPC Blocking Queries #17426

merged 2 commits into from May 23, 2023

Conversation

DanStough
Copy link
Member

@DanStough DanStough commented May 22, 2023 •
edited

Description

This PR adds blocking support to gRPC endpoints used for peering. Currently, these poll at a constant 1s interval. This is too slow for mesh gateway updates when using PeerThroughMeshGateways and too fast for steady-state updates that may trigger disco-chain compilation.

Testing & Reproduction steps

  • CI automated test
  • You can manually curl the HTTP endpoints using blocking query semantics and observe updates only on change.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@DanStough DanStough added backport/1.14 Changes are backported to 1.14 backport/1.15 Changes are backported to 1.15 labels May 22, 2023
@DanStough DanStough changed the title feat: initial grpc blocking queries [OSS] feat: initial grpc blocking queries May 22, 2023
@DanStough DanStough requested a review from a team as a code owner May 22, 2023 18:59
@DanStough DanStough force-pushed the dans/NET-1948/blocking-queries-attempt-3 branch from dd85cb9 to c14efa4 Compare May 22, 2023 19:54
@DanStough DanStough force-pushed the dans/NET-1948/blocking-queries-attempt-3 branch from c14efa4 to e3df1d8 Compare May 23, 2023 18:14
@DanStough DanStough changed the title [OSS] feat: initial grpc blocking queries [OSS] gRPC Blocking Queries May 23, 2023
@DanStough DanStough force-pushed the dans/NET-1948/blocking-queries-attempt-3 branch from 871ea48 to 5ceef20 Compare May 23, 2023 19:37
@DanStough DanStough merged commit d935c7b into main May 23, 2023
108 checks passed
@DanStough DanStough deleted the dans/NET-1948/blocking-queries-attempt-3 branch May 23, 2023 21:29
This was referenced May 23, 2023
Merged
Merged
nickethier pushed a commit that referenced this pull request May 26, 2023
@DanStough @nickethier
[OSS] gRPC Blocking Queries (#17426)
45a8117 
* feat: initial grpc blocking queries

* changelog and docs update
@p-linnane p-linnane mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashi-derek hashi-derek hashi-derek approved these changes

Assignees
No one assigned
Labels
backport/1.14 Changes are backported to 1.14 backport/1.15 Changes are backported to 1.15 pr/no-metrics-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanStough @hashi-derek