Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Backport of fix(connect envoy): set initial_fetch_timeout to wait for initial xDS into release/1.14" #17541

Merged
merged 1 commit into from Jun 1, 2023
Merged

Revert "Backport of fix(connect envoy): set initial_fetch_timeout to wait for initial xDS into release/1.14" #17541

merged 1 commit into from Jun 1, 2023

Conversation

DanStough
Copy link
Member

Reverts #17372.

@DanStough DanStough marked this pull request as draft June 1, 2023 14:21
@github-actions github-actions bot added the theme/cli Flags and documentation for the CLI interface label Jun 1, 2023
@DanStough DanStough force-pushed the revert-17372-dans/NET-3917/release-1.14/default-0s-initial_fetch_timeout branch from d4d8291 to a525ed0 Compare June 1, 2023 14:33
@DanStough DanStough marked this pull request as ready for review June 1, 2023 14:33
@DanStough DanStough requested a review from curtbushko June 1, 2023 14:34
curtbushko
curtbushko approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DanStough
Revert "Backport of fix(connect envoy): set initial_fetch_timeout to …
c00f3be 
…wait for initial xDS into release/1.14 (#17372)"

This reverts commit 886c2ef.
@DanStough DanStough force-pushed the revert-17372-dans/NET-3917/release-1.14/default-0s-initial_fetch_timeout branch from a525ed0 to c00f3be Compare June 1, 2023 15:03
@DanStough DanStough merged commit a2b41fd into release/1.14.x Jun 1, 2023
87 checks passed
@DanStough DanStough deleted the revert-17372-dans/NET-3917/release-1.14/default-0s-initial_fetch_timeout branch June 1, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

Assignees
No one assigned
Labels
pr/no-backport theme/cli Flags and documentation for the CLI interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanStough @curtbushko