Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list of Envoy versions #17547

Merged
merged 1 commit into from Jun 6, 2023
Merged

Update list of Envoy versions #17547

merged 1 commit into from Jun 6, 2023

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Jun 1, 2023

Description

Several new patch versions of Envoy have been released. This updates the list of supported Envoy versions to include those patch releases.

Also corrects an apparently accidental change in the minor version set supported by 1.14 in CI from backports.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added theme/contributing Additions and enhancements to community contributing materials theme/envoy/xds Related to Envoy support type/ci Relating to continuous integration (CI) tooling for testing or releases type/docs Documentation needs to be created/updated/clarified labels Jun 1, 2023
@zalimeni zalimeni added pr/no-backport pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. and removed type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials type/docs Documentation needs to be created/updated/clarified pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. labels Jun 1, 2023
@zalimeni zalimeni requested review from david-yu and jmurret June 1, 2023 21:10
zalimeni
zalimeni commented Jun 1, 2023
View reviewed changes
.github/workflows/test-integrations.yml
envoy-version: ["1.22.11", "1.23.8", "1.24.6", "1.25.4"]
envoy-version: ["1.21.6", "1.22.11", "1.23.9", "1.24.7"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the inclusion of 1.25 instead of 1.21 in this file was just a consequence of backports when the original was added. This seems correct to me to bring CI back in line w/ the rest of the code and docs.

@zalimeni zalimeni marked this pull request as ready for review June 1, 2023 21:11
@zalimeni zalimeni requested a review from a team as a code owner June 1, 2023 21:11
@zalimeni zalimeni mentioned this pull request Jun 1, 2023
Merged
4 tasks
trujillo-adam
trujillo-adam approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues for us on the docs side

@zalimeni
Copy link
Member Author

zalimeni commented Jun 6, 2023

@david-yu any concerns merging this?

@david-yu
Copy link
Contributor

david-yu commented Jun 6, 2023

Please go ahead and merge.

@zalimeni zalimeni merged commit c652a9f into release/1.14.x Jun 6, 2023
102 of 103 checks passed
@zalimeni zalimeni deleted the envoy-versions-1.14 branch June 6, 2023 19:48
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jun 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trujillo-adam trujillo-adam trujillo-adam approved these changes

@david-yu david-yu Awaiting requested review from david-yu

@jmurret jmurret Awaiting requested review from jmurret

Assignees
No one assigned
Labels
pr/no-backport theme/envoy/xds Related to Envoy support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zalimeni @david-yu @trujillo-adam