Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric names in Consul agent telemetry docs #17577

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

jjti
Copy link
Contributor

@jjti jjti commented Jun 5, 2023

Description

A seemingly random subset of counters have a . in their name which is incorrect (the metric names don't end in .)

Testing & Reproduction steps

Checked and a couple of these metrics do not, in fact, end in periods:

Screenshot 2023-06-05 at 5 30 13 PM

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jun 5, 2023
@jjti jjti changed the title Fix periods in Consul metric docs Fix periods in Consul agent telemetry docs Jun 5, 2023
@jjti jjti changed the title Fix periods in Consul agent telemetry docs Fix metric names in Consul agent telemetry docs Jun 5, 2023
@jjti jjti marked this pull request as ready for review June 5, 2023 21:28
@jjti jjti requested a review from a team as a code owner June 5, 2023 21:28
@jjti jjti added pr/no-metrics-test backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.14 labels Jun 5, 2023
@jjti jjti merged commit 7a2ee14 into main Jun 6, 2023
107 of 108 checks passed
@jjti jjti deleted the jjtimmons/fix-metric-periods branch June 6, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. pr/no-backport pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants