Disable peering queries by default in proxycfg #17731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashi-derek
force-pushed
the
derekm/disable-peering-default
branch
from
805df9f
to
36a6513
Compare
This PR disables peering functionality in proxycfg by default, unless `peering.enabled = true` is explicitly set in the agent config. This change was necessary to prevent expensive polling watch queries (that were introduced for peer upstreams) from impacting users that do not wish to leverage peering features. While this is technically a breaking change, the 1.13 implementation of peering is considered to be experimental and not production ready. After this PR is merged, any users that wish to use peering in conjunction with mesh will need to enable peering on each agent and server.
hashi-derek
force-pushed
the
derekm/disable-peering-default
branch
from
36a6513
to
f7ee779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables peering functionality in proxycfg by default, unless
peering.enabled = trueis explicitly set in the agent config.This change was necessary to prevent expensive polling watch queries (that were introduced for peer upstreams) from impacting users that do not wish to leverage peering features. While this is technically a breaking change, the 1.13 implementation of peering is considered to be experimental and not production ready. After this PR is merged, any users that wish to use peering in conjunction with mesh will need to enable peering on each agent and server.