Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💜 Cc 7187/purple banner for linking existing clusters #20275

Merged
merged 13 commits into from Jan 23, 2024

Conversation

chris-hut
Copy link
Contributor

Description

💜 We love purple banners!

This banner is the start of the work allowing users to link their existing Self managed clusters to HCP!
This banner will appear on the services index page:

  • If you have not already linked your cluster (to be implemented once we can detect that)
  • If you haven't dismissed the alert yet

And will disappear if you:

  • Link your cluster
  • Dismiss the alert (we save your choice in localStorage)

Testing & Reproduction steps

  • Go to the services page (http://localhost:4200/ui/dc1/services)
  • See the beautiful Banner
  • Press the buttons (only the informational links and dismiss button currently work)
  • When you dismiss the alert, check that when you refresh the page, the alert is no longer there 😮

Links

Screenshots

image

PR Checklist

  • updated test coverage

Follow ups

Once the ability to fetch linking status in https://hashicorp.atlassian.net/browse/CC-7145 lands, I'll create a fresh PR that the other checks that the hcp-link-status service makes

References

image

@github-actions github-actions bot added the theme/ui Anything related to the UI label Jan 19, 2024
Copy link
Contributor

@valeriia-ruban valeriia-ruban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiice 💜

@chris-hut chris-hut merged commit 5119667 into main Jan 23, 2024
91 checks passed
@chris-hut chris-hut deleted the CC-7187/purple-banner-for-linking-existing-clusters branch January 23, 2024 22:29
chris-hut added a commit that referenced this pull request Mar 11, 2024
chris-hut added a commit that referenced this pull request Mar 13, 2024
* Revert "feat: add alert to link to hcp modal to ask a user refresh a page; up… (#20682)"

This reverts commit dd833d9.

* Revert "chor: change cluster name param to have datacenter.name as default value (#20644)"

This reverts commit 8425cd0.

* Revert "chor: adds informative error message when acls disabled and read-only… (#20600)"

This reverts commit 9d712cc.

* Revert "Cc 7147 link to hcp modal (#20474)"

This reverts commit 8c05e57.

* Revert "Add nav bar item to show HCP link status and encourage folks to link (#20370)"

This reverts commit 22e6ce0.

* Revert "Cc 7145 hcp link status api (#20330)"

This reverts commit 049ca10.

* Revert "💜 Cc 7187/purple banner for linking existing clusters (#20275)"

This reverts commit 5119667.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants