GH-20889 - put conditionals are hcp initialization for consul server #20926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/cli
david-yu
approved these changes
Mar 28, 2024
mkam
approved these changes
Mar 28, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20889
HCP code is executing in cases where it not enabled in the
cloudstanza of the config. In this instance, thehcp-sdk-gomodule is trying to access the user's home directory.There is an upstream fix that needs to occur in
hcp-sdk-go. For now, in Consul, we will just wrap these code blocks in conditionals to see that HCP has been configured before running them.Testing & Reproduction steps
run consul in 1.18 without a HOME directory. then run this version
Links
PR Checklist