Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net 6820 customize mesh gateway limits #20945

Merged
merged 16 commits into from
Apr 16, 2024

Conversation

sarahalsmiller
Copy link
Member

Description

Allow users of Mesh Gateway to add custom circuit breakers to the mesh gateway XDS config by using a ServiceDefaults object named MeshGateway

Testing & Reproduction steps

  • Using a built image, tested creating a mesh gateway to make sure the snapshot was updated appropriately
  • Added a new golden file test to cover adding XDS

Links

PR Checklist

  • [ X ] updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@sarahalsmiller sarahalsmiller requested review from a team, andrewstucki and jm96441n and removed request for a team April 2, 2024 21:07
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Apr 2, 2024
@sarahalsmiller sarahalsmiller force-pushed the NET-6820-customize-mesh-gateway-limits branch from b747246 to cf7ea96 Compare April 2, 2024 21:08
.changelog/20945.txt Outdated Show resolved Hide resolved
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I do think creating a mesh-gateway configuration entry would be better since we're only really adding support for a specific field inside service-defaults to the mesh gateway; however, like you said, now isn't the time for that.

.changelog/20945.txt Outdated Show resolved Hide resolved
agent/proxycfg/mesh_gateway.go Outdated Show resolved Hide resolved
agent/proxycfg/mesh_gateway.go Outdated Show resolved Hide resolved
agent/proxycfg/snapshot.go Outdated Show resolved Hide resolved
agent/proxycfg/testing_mesh_gateway.go Outdated Show resolved Hide resolved
agent/proxycfg/testing_mesh_gateway.go Outdated Show resolved Hide resolved
agent/xds/clusters.go Outdated Show resolved Hide resolved
sarahalsmiller and others added 3 commits April 4, 2024 11:51
Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
Copy link
Contributor

@NiniOak NiniOak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good so I'm going to approve. You can wait for approval from others who have more context on this feature.

Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

agent/proxycfg/mesh_gateway.go Outdated Show resolved Hide resolved
@sarahalsmiller sarahalsmiller merged commit 08761f1 into main Apr 16, 2024
85 checks passed
@sarahalsmiller sarahalsmiller deleted the NET-6820-customize-mesh-gateway-limits branch April 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants