Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificate reload without restart #2584

Closed
Afterglow opened this issue Dec 8, 2016 · 22 comments
Closed

SSL certificate reload without restart #2584

Afterglow opened this issue Dec 8, 2016 · 22 comments
Labels
theme/config Relating to Consul Agent configuration, including reloading theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Milestone

Comments

@Afterglow
Copy link

I posted on the google groups and was directed here so here goes.

We use anchor by the openstack project to issue some of our remote nodes not within our own network with short lived SSL certificates. The result is that we have to restart consul frequently to pick up the new certificates. Is there any means to reload the SSL certificates without restarting consul completely? If not would this be considered as a feature request?

https://groups.google.com/forum/#!msg/consul-tool/SdHt8UJ8b_g/RpVnnGt5AAAJ

thanks!
Paul

@tniswong
Copy link

tniswong commented Feb 7, 2017

Would very much like to see this implemented ala reloadable configuration. I.e. Send a SIGHUP to reload TLS Cert/Key/CA's.

This enables automated cert rotation sans downtime, an effective compliment to the Autopilot Pattern via ContainerPilot.

@slackpad slackpad added type/enhancement Proposed improvement or new feature post-0.9 labels May 2, 2017
@slackpad slackpad added the theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner label May 25, 2017
@freman
Copy link

freman commented Jul 11, 2017

This explains why our vault + consul hasn't been behaving.

@shayangz
Copy link

For what is worth, I would vote for the timing/priority of this work being pushed forward. Full restart is very disruptive.

@freman
Copy link

freman commented Jul 11, 2017

Yeh that'd be nice, my confusion came from the fact that I'd written a nice tool to manage the certificates and had figured out the vault reload process and copied that to consul figuring "this is all hashicorp, they'd do it the same way" then 30 days later all my stuff stops working :(

Ok googles oh, it's consul reload... tweak all the things... 30 days later, same issue.

More googles oh, it's not currently possible without restart... this conversation :(

@tniswong
Copy link

Yeah. We worked around it by scripting a coordinated cluster failure/outage recovery...

https://www.consul.io/docs/guides/outage.html

@shayangz
Copy link

@slackpad: now that 0.9 is out the door do you think this can get on the roadmap?

@SoMuchToGrok
Copy link

SoMuchToGrok commented Nov 13, 2017

This feature is especially important when using nomad with TLS.

Currently, the built-in consul agent -> nomad health check is over HTTPS. When a new root CA is generated, and nomad is issued a server certificate signed by that new root CA, the consul agent requires a refresh of its trust anchors (which is currently a full restart of the service). Without the consul trust anchors being refreshed, the nomad health checks will fail. I would love to not restart consul, but just send it a SIGHUP instead.

Nomad is currently implementing this:
hashicorp/nomad#3479

@slackpad slackpad added this to the 1.0.2 milestone Nov 13, 2017
@slackpad
Copy link
Contributor

We shall draft off of Nomad's work for this one :-)

@slackpad slackpad modified the milestones: 1.0.2, 1.0.3 Dec 13, 2017
@slackpad slackpad modified the milestones: 1.0.3, Unplanned Jan 5, 2018
@slackpad slackpad removed the post-0.9 label Jan 5, 2018
@tniswong
Copy link

tniswong commented Jan 8, 2018

No love for this one? :(

@freman
Copy link

freman commented Feb 4, 2018

Literally causing us to abandon vault and ssl

@l33t0
Copy link

l33t0 commented Feb 4, 2018

Any updates?

@slackpad slackpad modified the milestones: Unplanned, Next Feb 5, 2018
@shayangz
Copy link

Just re-iterating how valuable this feature would be. 👍

@freman
Copy link

freman commented Mar 5, 2018

Pretty sure I could have forked and patched it by now... just sayin...

@banks
Copy link
Member

banks commented Mar 5, 2018

@freman PRs are welcome! :)

We're aware this is high on people's wishlist, as always we have a juggling act with various prorities. Thanks for your patience.

@SoMuchToGrok
Copy link

SoMuchToGrok commented Mar 5, 2018

To add some more input to this ticket, I think it would be incredibly useful if this was extended to include refreshing the root CA as well, not just the server certificate. One of the benefits of using Vault is how trivial it makes short-lived PKI certs, all the way up to the root CA.

@patelpu94
Copy link

Any update on this?

@mkeeler mkeeler added the theme/config Relating to Consul Agent configuration, including reloading label Apr 5, 2018
@mkeeler mkeeler mentioned this issue Jun 1, 2018
@tristanmorgan
Copy link
Member

The PR by @akshayganeshen is working well in a test environment for me but I need an Enterprise (pro) release of this for my client.

@banks
Copy link
Member

banks commented Sep 14, 2018

Thanks again for the patience folks. We are still working towards this as a TODO item.

I hope my comment on the PR is helpful context.

@kikitux
Copy link
Contributor

kikitux commented Sep 14, 2018

@tristanmorgan enterprise feedback have different channels, please feel free to reach me at alvaro hashicorp.com

@lmb
Copy link

lmb commented Nov 16, 2018

We're currently evaluating Consul, and this issue has popped up. We use short-ish lived certificates and can't afford to refresh these manually.

What are the chances of Step 1 in the comment from @banks happening without the fancier stuff?

@banks
Copy link
Member

banks commented Nov 16, 2018

@lmb the plans around TLS are being worked on now. Rebuilding this one way while in the misdst of designing a better overall solution doesn't seem like the wisest use of the resources we have but the next major release cycle has the whole TLS setup firmly in it's sights and will result in at least basic reloading working in a way that is compatible with our future plans -- hopefully more!

@hanshasselberg
Copy link
Member

We merged support for reloading TLS config into master: #5419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/config Relating to Consul Agent configuration, including reloading theme/operator-usability Replaces UX. Anything related to making things easier for the practitioner type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests