Provide stable config for agent/self #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good - just need to update https://www.consul.io/api/agent.html#read-configuration to match, and make a note about |
|
This is great. Thanks for the quick fix |
This patch adds a stable subset of the previous Config struct to the agent/self response. The actual runtime configuration is moved into DebugConfig and will be documented to change. Fixes #3530
magiconair
force-pushed
the
issue-3530-stable-self-config
branch
from
ea2a430
to
00fd9e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/v1/agent/self was exposing the previous internal config structure and some external services like Nomad and Consul itself relied on its format although it was never documented. Since we have refactored the runtime configuration to be independent from the config file configuration this change broke Nomad and others and we introduce a stable, documented
Configresponse to the agent/self response.Fixes #3530
Fixes hashicorp/nomad#3324