Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CheckID and Name to AgentServiceCheck struct #3788

Merged
merged 1 commit into from Jan 11, 2018
Merged

Added CheckID and Name to AgentServiceCheck struct #3788

merged 1 commit into from Jan 11, 2018

Conversation

jameshartig
Copy link
Contributor

See discussion in gitter.

Without CheckID and Name in the AgentServiceCheck struct, we can't set a name or ID when creating a check with a service. Ideally AgentServiceRegistration would just have a slice of AgentCheckRegistration structs but that would break existing clients.

@jameshartig
Copy link
Contributor Author

Any update on this? It's just adding 2 struct fields and it's blocking us. Thanks!

@slackpad slackpad merged commit 3278716 into hashicorp:master Jan 11, 2018
@slackpad
Copy link
Contributor

Thanks!

@slackpad slackpad added this to the 1.0.3 milestone Jan 11, 2018
@jameshartig jameshartig deleted the checkID branch August 16, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jameshartig @slackpad