Fix service tags not added to health check. Part two #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - thank you @42wim! I'm going to see if I can add a better unit test to cover this and then will merge shortly. |
|
@42wim what was the impact then? The heathcheck result being sent to leader? |
|
@pierresouchay Yes and the fact that this causes to change/update the |
fboismenu
pushed a commit
to criteo-forks/consul
that referenced
this pull request
Jan 30, 2018
fboismenu
pushed a commit
to criteo-forks/consul
that referenced
this pull request
Jan 30, 2018
slackpad
added a commit
that referenced
this pull request
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue in my comment
#3259 (comment) on #3259
It also adds the ServiceTags to the check, otherwise the check will differ because the local one has a nil entry for ServiceTags but the server state has the actual ServiceTags in the check.
Related to #3642